fix(x-editable): choice value update crash with 0 value #7335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the weak comparison, if we try to update a choice list field with a value of 0, it is considered as a violation.
soullivaneuh
force-pushed
the
x-editable-0-value
branch
from
0986eb7 to
878728a
Compare
VincentLanglet
approved these changes
Jul 19, 2021
jordisala1991
approved these changes
Jul 19, 2021
|
Thanks @soullivaneuh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the weak comparison, if we try to update a choice list field
with a value of 0, it is considered as a violation.
Subject
I am targeting this branch, because: #7289 (comment).
Closes #5231.
Changelog